Skip to content

Add graphql-hooks client library #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Add graphql-hooks client library #990

merged 2 commits into from
Dec 15, 2020

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Dec 12, 2020

No description provided.

@orta
Copy link
Member

orta commented Dec 13, 2020

Hi, it'd be great if you added some markdown to that file describing how to use the API and give folks a reason to dig deeper

@simoneb
Copy link
Contributor Author

simoneb commented Dec 13, 2020

Hi, it'd be great if you added some markdown to that file describing how to use the API and give folks a reason to dig deeper

I've extended the description a bit

@orta
Copy link
Member

orta commented Dec 15, 2020

Sure, you're welcome to skip the markdown

@orta orta merged commit d3a93fb into graphql:source Dec 15, 2020
@simoneb
Copy link
Contributor Author

simoneb commented Dec 15, 2020

Sure, you're welcome to skip the markdown

I didn't mean to reject your advice, I simply kept it in line with the other client libraries listed in that same page, which are not providing more than a description, unless I missed something.

@simoneb simoneb deleted the patch-1 branch December 15, 2020 09:13
@orta
Copy link
Member

orta commented Dec 15, 2020

Yeah, I'm not offended 👍🏻

The markdown section is new, and we've not been actively going back to add them to older libs. Showing their API usage just makes it easier for folks to make informed decisions without a lot of clicks.

@simoneb
Copy link
Contributor Author

simoneb commented Dec 15, 2020

I only now realized what you meant. I missed it because none of the client libraries in the same group provides examples, but the servers do. I did it in #991. Thanks for bringing that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants