-
Notifications
You must be signed in to change notification settings - Fork 710
Clarify splitting/passing behaviour for --*-option(s) arguments #10792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomsmeding
wants to merge
7
commits into
haskell:master
Choose a base branch
from
tomsmeding:options-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikolaj
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
geekosaur
requested changes
Apr 10, 2025
geekosaur
approved these changes
Apr 11, 2025
@mergify rebase |
This handles geekosaur's review.
Co-authored-by: brandon s allbery kf8nh <[email protected]>
✅ Branch has been successfully rebased |
@tomsmeding: could you set a squash&merge label? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
attention: needs-review
ready and waiting
Mergify is waiting out the cooldown period
squash+merge me
Tell Mergify Bot to squash-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned by a question on IRC of what exactly
--ghc-option
,--ghc-options
and--repl-options
take as their input format, I reformulated and expanded on the relevant documentation. Correctness of this information was checked in two ways:cabal
CLI;This list conspicuously excludes "looking at the code". My apologies.
Checklist for template B (does not modify behaviour or interface):