Skip to content

Set <pkgname_datadir> to an absolute path #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025
Merged

Set <pkgname_datadir> to an absolute path #10830

merged 2 commits into from
Apr 6, 2025

Conversation

mpickering
Copy link
Collaborator

Ticket #10717 points out that the _datadir environment variable
should be set to an absolute path since the test executables may
change directory during their invocation.

This is easily fixed by using the absoluteWorkingDirLBI
function, which was introduced in 027bddf,

Fixes #10717


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@mpickering mpickering requested a review from sheaf March 14, 2025 13:05
@Mikolaj
Copy link
Member

Mikolaj commented Mar 17, 2025

I take it you deem this ready for review, so let me add the label for that.

@mpickering
Copy link
Collaborator Author

@ulysses4ever I have put up a backport on #10838. I don't plan to make any more changes to the backport, so the person preparing the release can decide what a suitable course of action is and modify that patch or this patch as they deem necessary.

@ulysses4ever
Copy link
Collaborator

Sounds good, thanks @mpickering !

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Mar 27, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Mar 27, 2025
@Mikolaj
Copy link
Member

Mikolaj commented Mar 27, 2025

Apparently, conflicts prevent a merge.

BTW, should this be backported to 3.14? [Edit: it already is, in a different form.]

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 31, 2025
@mergify mergify bot added the waiting too long automatically set by Mergify to trigger a warning label Apr 6, 2025
Ticket #10717 points out that the <pkgname>_datadir environment variable
should be set to an absolute path since the test executables may
change directory during their invocation.

This is easily fixed by using the absoluteWorkingDirLBI
function, which was introduced in 027bddf,

Fixes #10717
The test checks that if you change directory when running a test
executable that you can still access datafiles.
@ulysses4ever
Copy link
Collaborator

It looks like it was my inline comment above (#10830 (comment)) that was holding it back. Resolving...

@ulysses4ever ulysses4ever removed the waiting too long automatically set by Mergify to trigger a warning label Apr 6, 2025
@ulysses4ever ulysses4ever removed this from the cabal-install 3.14.2.0 milestone Apr 6, 2025
@mergify mergify bot merged commit e49dc81 into master Apr 6, 2025
54 checks passed
@mergify mergify bot deleted the wip/t10717 branch April 6, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't backport merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period regression in 3.14
Projects
None yet
5 participants