-
Notifications
You must be signed in to change notification settings - Fork 710
Set <pkgname_datadir> to an absolute path #10830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I take it you deem this ready for review, so let me add the label for that. |
@ulysses4ever I have put up a backport on #10838. I don't plan to make any more changes to the backport, so the person preparing the release can decide what a suitable course of action is and modify that patch or this patch as they deem necessary. |
Sounds good, thanks @mpickering ! |
Apparently, conflicts prevent a merge. BTW, should this be backported to 3.14? [Edit: it already is, in a different form.] |
The test checks that if you change directory when running a test executable that you can still access datafiles.
It looks like it was my inline comment above (#10830 (comment)) that was holding it back. Resolving... |
Ticket #10717 points out that the _datadir environment variable
should be set to an absolute path since the test executables may
change directory during their invocation.
This is easily fixed by using the absoluteWorkingDirLBI
function, which was introduced in 027bddf,
Fixes #10717
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.