Skip to content

testsuite: Supress stderr when running integration tests #10837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

mpickering
Copy link
Collaborator

This fixes a problem where test output was leaking into GitHub Actions results (#8419), making the output unnecessarily verbose and harder to read.

This makes the test output much cleaner while still preserving all the diagnostic information when tests fail.

Fixes #8419

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@mpickering mpickering force-pushed the wip/8419 branch 2 times, most recently from dc309c9 to e5fcdf4 Compare March 20, 2025 09:58
@ulysses4ever
Copy link
Collaborator

No updates for two weeks: just a gentle ping @mpickering! I know it's low priority but it'd be nice to get it done, and it's really close now. As usual, feel free to signal that you'd like someone else to pick it up.

@Bodigrim do you want to resolve your comments that were addressed?

@Bodigrim
Copy link
Collaborator

Bodigrim commented Apr 6, 2025

Sure, I resolved comments which were addressed. The remaining two are suggestions, but not blockers, up to you.

@mpickering
Copy link
Collaborator Author

I have resolved @Bodigrim's comments now.

@ulysses4ever
Copy link
Collaborator

@Bodigrim do you think you could give a formal GitHub approval here?

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Apr 11, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Apr 11, 2025
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 14, 2025
This fixes a problem where test output was leaking into GitHub Actions
results (#8419), making the output unnecessarily verbose and harder to read.

This makes the test output much cleaner while still preserving all the
diagnostic information when tests fail.

Also force the test to run sequentially, they fail if you try to run
them concurrently. I think that there are probably issues to do with
setting the working directory when using cabal-install as a library.

Fixes #8419
Copy link
Contributor

mergify bot commented Apr 14, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@ulysses4ever
Copy link
Collaborator

@mergify rebase

Copy link
Contributor

mergify bot commented Apr 14, 2025

rebase

☑️ Nothing to do

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@ulysses4ever
Copy link
Collaborator

@mergify requeue

Copy link
Contributor

mergify bot commented Apr 14, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@ulysses4ever
Copy link
Collaborator

Seemed like a transient Windows failure, so I tried to restart.

@mergify mergify bot merged commit 5edaf1b into master Apr 14, 2025
56 checks passed
@mergify mergify bot deleted the wip/8419 branch April 14, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: github action error annotations despite passing tests
4 participants