-
Notifications
You must be signed in to change notification settings - Fork 710
testsuite: Supress stderr when running integration tests #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dc309c9
to
e5fcdf4
Compare
No updates for two weeks: just a gentle ping @mpickering! I know it's low priority but it'd be nice to get it done, and it's really close now. As usual, feel free to signal that you'd like someone else to pick it up. @Bodigrim do you want to resolve your comments that were addressed? |
Sure, I resolved comments which were addressed. The remaining two are suggestions, but not blockers, up to you. |
I have resolved @Bodigrim's comments now. |
@Bodigrim do you think you could give a formal GitHub approval here? |
This fixes a problem where test output was leaking into GitHub Actions results (#8419), making the output unnecessarily verbose and harder to read. This makes the test output much cleaner while still preserving all the diagnostic information when tests fail. Also force the test to run sequentially, they fail if you try to run them concurrently. I think that there are probably issues to do with setting the working directory when using cabal-install as a library. Fixes #8419
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
@mergify rebase |
☑️ Nothing to do
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Seemed like a transient Windows failure, so I tried to restart. |
This fixes a problem where test output was leaking into GitHub Actions results (#8419), making the output unnecessarily verbose and harder to read.
This makes the test output much cleaner while still preserving all the diagnostic information when tests fail.
Fixes #8419
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: