WIP: Sketch: API changes for CIP-0073 #2483
Draft
+450
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divam <[email protected]>
isegall-da
reviewed
Oct 10, 2025
| type: string | ||
| format: date-time | ||
| description: | | ||
| Expiry time of the proposal. Must be within 7 days from now. |
There was a problem hiding this comment.
within 7 days
You mean any time up to 7 days from now?
If you expect a specific value exactly 7 days from now, then it feels a bit weird to even make it an argument. Consider hard-coding server side instead initially.
isegall-da
reviewed
Oct 10, 2025
| /v0/admin/minting-delegation-proposals: | ||
| get: | ||
| description: | | ||
| List all MintingDelegationProposal contracts where the delegate is the validator operator. |
There was a problem hiding this comment.
missing a limit on the number of responses, and pagination
isegall-da
reviewed
Oct 10, 2025
| /v0/admin/minting-delegations: | ||
| get: | ||
| description: | | ||
| List all MintingDelegation contracts where the delegate is the validator operator. |
There was a problem hiding this comment.
also missing limit and pagination
meiersi-da
reviewed
Oct 15, 2025
| "501": | ||
| $ref: "../../../../common/src/main/openapi/common-external.yaml#/components/responses/501" | ||
|
|
||
| /v0/admin/external-party/minting-delegation-proposal/prepare-send: |
There was a problem hiding this comment.
I'm not sure we want to create these endpoints for the following reasons:
- We want people to work straight against the Ledger API where possible; and it is possible here.
- The proposal does not require fetching extra context. So it is as simple as calling
prepareand thenexecute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for design-doc review purpose.