Removing unnecessary parenthesis

icecoder · rotelok · Jun 16, 2018 · Jun 16, 2018 · Jun 16, 2018 · Jun 16, 2018
commit 05ee5e5f7020d74336b7a60c7ef42b2268d85bf6
diff --git a/editor.php b/editor.php
@@ -1,6 +1,6 @@
 <?php
-include("lib/headers.php");
-include("lib/settings.php");
+include "lib/headers.php";
+include "lib/settings.php";
 $t = $text['editor'];
 ?>
 <!DOCTYPE html>
@@ -317,7 +317,7 @@ function createNewCMInstance(num) {
 
 <div style="position: absolute; display: none; height: 100%; width: 100%; top: 0; padding: 3px 0 0 60px; line-height: 16px; font-family: monospace; font-size: 13px; z-index: 2147483647" id="game"></div>
 
-<?php include_once("processes/on-editor-load.php"); ?>
+<?php include_once "processes/on-editor-load.php"; ?>
 
 </body>
 

diff --git a/files.php b/files.php
@@ -1,6 +1,6 @@
 <?php
-include("lib/headers.php");
-include("lib/settings.php");
+include "lib/headers.php";
+include "lib/settings.php";
 $t = $text['files'];
 
 // Is our dir in the list of GitHub local paths?

diff --git a/index.php b/index.php
@@ -1,6 +1,6 @@
 <?php
-include("lib/headers.php");
-include("lib/settings.php");
+include "lib/headers.php";
+include "lib/settings.php";
 $t = $text['index'];
 
 $updateMsg = '';

diff --git a/lib/auto-logout-warning.php b/lib/auto-logout-warning.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['auto-logout-warning'];
 ?>
 <!DOCTYPE html>
@@ -21,4 +21,4 @@
 
 </body>
 
-</html>
+</html>
diff --git a/lib/backup-versions-preview-loader.php b/lib/backup-versions-preview-loader.php
@@ -1,7 +1,7 @@
 <?php
 // Load common functions
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 
 $file = str_replace("|","/",xssClean($_GET['file'],'html'));
 
@@ -33,4 +33,4 @@
 parent.document.getElementById('buttonsContainer').style.display = 'inline-block';
 parent.editor.setValue(document.getElementById('loadedFile').value);
 parent.document.getElementById('infoContainer').innerHTML = 'Date & Time:<br><?php echo $datetime;?><br><br>Size:<br><?php echo $size;?>';
-</script>
+</script>
diff --git a/lib/backup-versions.php b/lib/backup-versions.php
@@ -1,7 +1,7 @@
 <?php
 // Load common functions
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $text = $_SESSION['text'];
 $t = $text['backup-versions'];
 
@@ -110,7 +110,7 @@
 
 <?php
 echo "fileName = '".basename($file)."';";
-include(__DIR__."/language-modes-partial.js");
+include __DIR__."/language-modes-partial.js";
 ?>
 
 var editor = CodeMirror.fromTextArea(document.getElementById("code"), {

diff --git a/lib/bug-files-check.php b/lib/bug-files-check.php
@@ -1,7 +1,7 @@
 <?php
 // Load common functions
-include("headers.php");
-include_once("settings-common.php");
+include "headers.php";
+include_once "settings-common.php";
 $text = $_SESSION['text'];
 $t = $text['bug-files-check'];
 
@@ -107,7 +107,7 @@
 );
 
 // Include our process once our bug checking work is done
-include("../processes/on-bug-check.php");
+include "../processes/on-bug-check.php";
 
 // Finally, display our status in JSON format as the XHR response text
 echo json_encode($status);

diff --git a/lib/download.php b/lib/download.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 
 // Establish the real absolute path to the file
 $file = realpath($docRoot.$iceRoot.str_replace("|","/",strClean($_GET['file'])));
@@ -24,4 +24,4 @@
     readfile($file);
     exit;
 }
-?>
+?>
diff --git a/lib/file-control-xhr.php b/lib/file-control-xhr.php
@@ -1,7 +1,7 @@
 <?php
-include("headers.php");
-include("settings.php");
-include("ftp-control.php");
+include "headers.php";
+include "settings.php";
+include "ftp-control.php";
 $t = $text['file-control'];
 
 // ===============================
@@ -260,7 +260,7 @@ function stitchChanges($fileLines) {
 			// MDT'S MATCH, WRITE FILE
 			// =======================
 
-			if (!(isset($_GET['fileMDT']))||$filemtime==$_GET['fileMDT']) {
+			if (!isset($_GET['fileMDT']) ||$filemtime==$_GET['fileMDT']) {
 
 				// FTP Saving
 				if (isset($ftpSite)) {
@@ -485,7 +485,7 @@ function stitchChanges($fileLines) {
 						top.ICEcoder.redoTabHighlight(top.ICEcoder.selectedTab);';
 
 				// Run our custom processes
-				include_once("../processes/on-file-save.php");
+				include_once "../processes/on-file-save.php";
 
 			// ======================================================
 			// MDT'S DON'T MATCH, OFFER TO LOAD FILE & SHOW DIFF VIEW
@@ -557,7 +557,7 @@ function stitchChanges($fileLines) {
 		}
 		$finalAction = "newFolder";
 		// Run our custom processes
-		include_once("../processes/on-new-dir.php");
+		include_once "../processes/on-new-dir.php";
 	} else {
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot create...']."\\\\n".$fileLoc."');";
 		$finalAction = "nothing";
@@ -603,7 +603,7 @@ function stitchChanges($fileLines) {
 			}
 			$finalAction = "move";
 			// Run our custom processes
-			include_once("../processes/on-file-dir-move.php");
+			include_once "../processes/on-file-dir-move.php";
 		} else {
 			$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot move']."\\\\n".str_replace("|","/",strClean($_GET['oldFileName']))."\\\\n\\\\n".$t['Maybe public write...']."');";
 			$finalAction = "nothing";
@@ -641,7 +641,7 @@ function stitchChanges($fileLines) {
 		}
 		$finalAction = "rename";
 		// Run our custom processes
-		include_once("../processes/on-file-dir-rename.php");
+		include_once "../processes/on-file-dir-rename.php";
 	} else {
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot rename']."\\\\n".strClean($_GET['oldFileName'])."\\\\n\\\\n".$t['Maybe public write...']."');";
 		$finalAction = "nothing";
@@ -698,7 +698,7 @@ function stitchChanges($fileLines) {
 		$doNext .= 'top.ICEcoder.updateFileManagerList(\'add\',\''.strClean(str_replace("|","/",$_GET['location'])).'\',\''.basename($dest).'\',false,false,false,\''.$fileOrFolder.'\');';
 		$finalAction = "pasteFile";
 		// Run our custom processes
-		include_once("../processes/on-file-dir-paste.php");
+		include_once "../processes/on-file-dir-paste.php";
 	} else {
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot copy']." \\\\n".str_replace($docRoot,"",$source)."\\\\n ".$t['into']." \\\\n".str_replace($docRoot,"",$dest)."');";
 		$finalAction = "nothing";
@@ -759,7 +759,7 @@ function getDetails($fileArr) {
 			$fileUploader=new fileUploader($uploads);
 		}
 		// Run our custom processes
-		include_once("../processes/on-file-upload.php");
+		include_once "../processes/on-file-upload.php";
 	} else {
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot upload...']."');";
 		$finalAction = "nothing";
@@ -789,7 +789,7 @@ function getDetails($fileArr) {
 				$doNext .= 'top.ICEcoder.selectedFiles=[];top.ICEcoder.updateFileManagerList(\'delete\',\''.$fileLoc.'\',\''.$fileName.'\');';
 				$finalAction = "delete";
 				// Run our custom processes
-				include_once("../processes/on-file-dir-delete.php");
+				include_once "../processes/on-file-dir-delete.php";
 			} else {
 				$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot delete']."\\\\n".$fileLoc."/".$fileName."');";
 				$finalAction = "nothing";
@@ -823,7 +823,7 @@ function getDetails($fileArr) {
 				$doNext .= 'top.ICEcoder.selectedFiles=[];top.ICEcoder.updateFileManagerList(\'delete\',\''.$fileLoc.'\',\''.$fileName.'\');';
 				$finalAction = "delete";
 				// Run our custom processes
-				include_once("../processes/on-file-dir-delete.php");
+				include_once "../processes/on-file-dir-delete.php";
 			} else {
 				$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot delete']."\\\\n".str_replace($docRoot,"",$fullPath)."');";
 				$finalAction = "nothing";
@@ -870,7 +870,7 @@ function rrmdir($dir) {
 		fclose($fh);
 		$finalAction = "replaceText";
 		// Run our custom processes
-		include_once("../processes/on-file-replace-text.php");
+		include_once "../processes/on-file-replace-text.php";
 	} else {
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot replace...']."\\\\n".$file."');";
 		$finalAction = "nothing";
@@ -894,7 +894,7 @@ function rrmdir($dir) {
 		$doNext .= 'top.ICEcoder.goToLine('.$lineNumber.');';
 		$finalAction = "getRemoteFile";
 		// Run our custom processes
-		include_once("../processes/on-get-remote-file.php");
+		include_once "../processes/on-get-remote-file.php";
 	} else {
 		$finalAction = "nothing";
 		$doNext .= 'top.ICEcoder.message(\''.$t['Sorry, could not...'].' '.$file.'\');';
@@ -929,7 +929,7 @@ function rrmdir($dir) {
 		}
 		$finalAction = "perms";
 		// Run our custom processes
-		include_once("../processes/on-file-dir-perms.php");
+		include_once "../processes/on-file-dir-perms.php";
 	} else {
 		$finalAction = "nothing";
 		$doNext .= "top.ICEcoder.message('".$t['Sorry, cannot change...']." \\n".strClean($file)."');";

diff --git a/lib/file-control.php b/lib/file-control.php
@@ -1,7 +1,7 @@
 <?php
-include("headers.php");
-include("settings.php");
-include("ftp-control.php");
+include "headers.php";
+include "settings.php";
+include "ftp-control.php";
 $t = $text['file-control'];
 ?>
 <?php if ($_SESSION['githubDiff']) { ?>
@@ -118,7 +118,7 @@
 			$loadedFile = preg_replace('/\\n/','&#13;',$loadedFile);
 			echo '</script><textarea name="loadedFile" id="loadedFile">'.$loadedFile.'</textarea><script>';
 			// Run our custom processes
-			include_once("../processes/on-file-load.php");
+			include_once "../processes/on-file-load.php";
 		} else if (strpos($finfo,"image")===0) {
 			echo 'fileType="image";fileName=\''.$fileLoc."/".$fileName.'\';';
 		} else {

diff --git a/lib/ftp-manager.php b/lib/ftp-manager.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['ftp-manager'];
 
 // If we have an action to perform

diff --git a/lib/get-branch.php b/lib/get-branch.php
@@ -1,8 +1,8 @@
 <?php
 if (!isset($ICEcoder['root'])) {
-	include("headers.php");
-	include("settings.php");
-	include("ftp-control.php");
+	include "headers.php";
+	include "settings.php";
+	include "ftp-control.php";
 }
 
 if (!$_SESSION['loggedIn']) {
@@ -100,7 +100,7 @@ function parseGitignore($file) { # $file = '/absolute/path/to/.gitignore'
 	// Exclude the .git dir as first item as we don't want to see that
 	$excluded = array("/.git");
 	foreach ($gi as $scanpath) {
-		$excludedTest = (parseGitignore($scanpath));
+		$excludedTest = parseGitignore($scanpath);
 		if (count($excludedTest) > 0) {
 			$excluded = array_merge($excluded, $excludedTest);
 		}

diff --git a/lib/github-manager.php b/lib/github-manager.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['github-manager'];
 
 // If we have an action to perform

diff --git a/lib/github.php b/lib/github.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['github'];
 
 // SSL check, as everything is over https

diff --git a/lib/go-localhost-root.php b/lib/go-localhost-root.php
@@ -1,5 +1,5 @@
 <?php
-include_once("settings.php");
+include_once "settings.php";
 $text = $_SESSION['text'];
 $t = $text['settings-update'];
 
@@ -15,7 +15,7 @@
 	$settingsContents =
 		substr($settingsContents,0,$repPosStart).
 		'"root"			=> "",'.PHP_EOL.
-		substr($settingsContents,($repPosEnd),strlen($settingsContents));
+		substr($settingsContents, $repPosEnd,strlen($settingsContents));
 
 	// Now update the config file
 	if (is_writable($settingsFile)) {

diff --git a/lib/headers.php b/lib/headers.php
@@ -5,7 +5,7 @@
 }
 
 // Load common functions
-include_once(__DIR__."/settings-common.php");
+include_once __DIR__."/settings-common.php";
 if (isset($_SESSION['text'])) {
 	$text = $_SESSION['text'];
 	$t = $text['headers'];

diff --git a/lib/help.php b/lib/help.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['help'];
 ?>
 <!DOCTYPE html>

diff --git a/lib/login.php b/lib/login.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['login'];
 ?>
 <!DOCTYPE html>

diff --git a/lib/multiple-results.php b/lib/multiple-results.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['multiple-results'];
 ?>
 <?php

diff --git a/lib/plugins-display.php b/lib/plugins-display.php
@@ -1,5 +1,5 @@
 <?php
-include("headers.php");
+include "headers.php";
 
 $onLoadExtras = "";
 $pluginsDisplay = "";

diff --git a/lib/plugins-manager.php b/lib/plugins-manager.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['plugins-manager'];
 
 // Set the plugin data source

diff --git a/lib/properties.php b/lib/properties.php
@@ -1,6 +1,6 @@
 <?php
-include("headers.php");
-include("settings.php");
+include "headers.php";
+include "settings.php";
 $t = $text['properties'];
 
 // Establish the real absolute path to the file/folder

diff --git a/lib/session-active-ping.php b/lib/session-active-ping.php
@@ -1,6 +1,6 @@
 <?php
 // Load headings and settings
 // Do this every 5 mins to keep session alive
-include("headers.php");
-include("settings.php");
-?>
+include "headers.php";
+include "settings.php";
+?>