ipython notebook uploads #1047
Open
ipython notebook uploads #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Feb 14, 2024
Owner
|
LMK when this is ready to look at/merge. So far, I'm refraining from taking a detailed look while it's still in draft status. |
Collaborator
Author
Go ahead now. I've tested the functionality locally. If a unit test would help, I'll add. |
Collaborator
Author
|
Any else needed here? |
inducer
reviewed
Feb 28, 2024
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
LGTM. Just one wrinkle, then this should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nbformat>= 4