feature/debian #10
Merged
feature/debian #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
There was a problem hiding this comment.
There are no SQL schema generated for every packetfence version, it's only if the schema was updated so this, while clever, won't work.
Ignore my comment. It's actually very clever and will work. I'm integrating that for the RPM version. :)
Contributor
Author
|
Other tasks
|
debian/rules
Outdated
Contributor
Author
There was a problem hiding this comment.
How does the rules file knows if it's doing pfdetect_remote or not?
Member
There was a problem hiding this comment.
It knows from the directory $(CURDIR)/debian/packetfence-remote-snort-sensor
Contributor
Author
|
|
dropped the relvant patch from debian/patches/
- refactored allowed services and binary name lists into a global list and a regex built from it - renamed $exe to $binary to avoid confusion
This prevents at least one bug where freeradius would have been started on debian even if disabled. Also, daemon names will be consistent inside packetfence but proper binary names displayed too where relevant.
removed several patches from debian/patches/
permissions multi-line Depends
Member
|
Rebased |
Contributor
Author
|
good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c'est prêt!