feature/sponsored guests code review #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guest template updated config / doc updated also presenting the options in the signup page a little more cleanly
like we recently did with the billing stuff
rewritten most of the form validator too: - proper email validation from pf::web::util - proper phone number validation from pf::web::util - performing per-guest-mode field validation
replaced all token, pid, username, etc. to guest_pid (avoid clash in sessions) got rid of an extra test in sms reg that was no longer required other little things
moved templates around and their refering constants renamed an api call
also I'm pretty sure I avoided a bug in the eval error handling (a $msg redefinition)
it can send emails to the sponsor
required schema change
extracted in it's own sub (easier to override) localdomain requirement extracted in a configuration parameter
easier for users to override and way more flexible will also be tied to the authentication portion once I integrate that
This is a beginning of adding configuration options to the categories. To better reflect its use, node categories were moved out of the node tab into configuration tab on the Web Admin
This naming is more coherent with to-be-introduced self pre-registration.
- SMS was decided to be out of scope - email will not work as-is (for now) - Firewall / Apache ACLs still to be done
When requesting the footer you can say whether or not you want the footer's help. This allows for easy turn off in guest pre-registration workflows.
increases attack surface - firewall opens https on mgmt interface - apache ACLs allows access to /signup
extract all subjects into i18n to allow easy overloading so one not satisified with it can replace the string with an appropriate msgstr "..." in conf/locale/
This allows us to use format strings (i18n_format) in the calling code and benefit from translatable errors, etc.
…-site Useful if the sponsor requests himself the access.
Contributor
Author
|
We plan on releasing 3.3 this week. This would need to be acknowledged by one of you soon. |
Contributor
|
Approved. Go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgx @dereksky can one of you guys review please?