code review for feature/roles-experiment #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: returns hardcoded role string for now! new supportsRoleBasedEnforcement() hook that modules must override if they support role-based new returnRoleAttribute() hook to return the VSA to set Aruba support basic tests for the role-supported network devices
stub getRoleByName() for now
extension tests are now all running the same code and extension points only listed in a test list
connected to CLI/Web UI added to pf::SNMP base class added to switch factory
performs caching of the roles parsing on first hit
…eature/roles-experiment
Contributor
Author
|
@fgaudreault told me some issues to look at:
|
Implementation differs than other modules. AeroHive uses Tunnel Attributes for role assignment and this is what is also used for the VLAN assignments. Since we can't use both at the same time we favor roles if they are configured and VLANs otherwise. This meant overriding the base role support implementation from pf::SNMP into the AeroHive module.
lib/pf/SNMP.pm
Outdated
Contributor
There was a problem hiding this comment.
r_assign? not really self-documenting ;)
Contributor
There was a problem hiding this comment.
maybe reorder theses one for consistency purposes
Contributor
Author
There was a problem hiding this comment.
I think putting instance() on top makes it clearer that we are dealing with a singleton. pf::SwitchFactory is structured that way too.
Contributor
Author
|
thank you dear for your review |
Contributor
|
my pleasure sir! |
stegar123
pushed a commit
to stegar123/packetfence
that referenced
this pull request
Jan 17, 2024
…b_handles Feature/make reset db handles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for review.