Skip to content

docs(vue): Remove TypeScript dependencies: tsconfig.json file #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023
Merged

docs(vue): Remove TypeScript dependencies: tsconfig.json file #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a924d03
Remove TypeScript dependencies: tsconfig.json file
yusufsahinhamza Jan 5, 2023
dfbda9c
Merge branch 'main' into pr/2689
brandyscarney Apr 12, 2023
7045b9b
add vue change to v6 docs
brandyscarney Apr 12, 2023
76686aa
docs(vue): include folder name in ts steps
brandyscarney Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions docs/vue/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,17 @@ So, if you’d prefer to use JavaScript instead of TypeScript, you can. After ge
npm uninstall --save typescript @types/jest @typescript-eslint/eslint-plugin @typescript-eslint/parser @vue/cli-plugin-typescript @vue/eslint-config-typescript
```

2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `router/index.ts` and `main.ts`.
2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `src/router/index.ts` and `src/main.ts`.

3. Remove `@vue/typescript/recommended` and `@typescript-eslint/no-explicit-any: ‘off’, `from `.eslintrc.js`.

4. Remove `Array<RouteRecordRaw>` from `router/index.js`.
4. Remove `Array<RouteRecordRaw>` from `src/router/index.js`.

5. Delete the `shims-vue.d.ts` file.
5. Delete the `src/shims-vue.d.ts` file.

6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `App.vue` and `views/HomePage.vue`.
6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `src/App.vue` and `src/views/HomePage.vue`.

7. Delete the `tsconfig.json` file.

## A look at a Vue Component

Expand Down
10 changes: 6 additions & 4 deletions versioned_docs/version-v5/vue/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,17 @@ So, if you’d prefer to use JavaScript instead of TypeScript, you can. After ge
npm uninstall --save typescript @types/jest @typescript-eslint/eslint-plugin @typescript-eslint/parser @vue/cli-plugin-typescript @vue/eslint-config-typescript
```

2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `router/index.ts` and `main.ts`.
2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `src/router/index.ts` and `src/main.ts`.

3. Remove `@vue/typescript/recommended` and `@typescript-eslint/no-explicit-any: ‘off’, `from `.eslintrc.js`.

4. Remove `Array<RouteRecordRaw>` from `router/index.js`.
4. Remove `Array<RouteRecordRaw>` from `src/router/index.js`.

5. Delete the `shims-vue.d.ts` file.
5. Delete the `src/shims-vue.d.ts` file.

6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `App.vue` and `views/Home.vue`.
6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `src/App.vue` and `src/views/HomePage.vue`.

7. Delete the `tsconfig.json` file.

## A look at a Vue Component

Expand Down
13 changes: 8 additions & 5 deletions versioned_docs/version-v6/vue/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,17 @@ So, if you’d prefer to use JavaScript instead of TypeScript, you can. After ge
npm uninstall --save typescript @types/jest @typescript-eslint/eslint-plugin @typescript-eslint/parser @vue/cli-plugin-typescript @vue/eslint-config-typescript
```

2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `router/index.ts` and `main.ts`.
2. Change all `.ts` files to `.js`. In a blank Ionic Vue app, this should only be `src/router/index.ts` and `src/main.ts`.

3. Remove `@vue/typescript/recommended` and `@typescript-eslint/no-explicit-any: ‘off’, `from `.eslintrc.js`.

4. Remove `Array<RouteRecordRaw>` from `router/index.js`.
4. Remove `Array<RouteRecordRaw>` from `src/router/index.js`.

5. Delete the `shims-vue.d.ts` file.
5. Delete the `src/shims-vue.d.ts` file.

6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `App.vue` and `views/HomePage.vue`.
6. Remove `lang="ts"` from the `script` tags in any of your Vue components that have them. In a blank Ionic Vue app, this should only be `src/App.vue` and `src/views/HomePage.vue`.

7. Delete the `tsconfig.json` file.

## A look at a Vue Component

Expand Down Expand Up @@ -324,7 +326,7 @@ Let's look at another component from Ionic Framework, FAB. Floating Action Butto
</template>

<script setup>
import { IonBadge, IonCheckbox, IonContent, IonFab, IonFabButton, IonHeader, IonItem, IonLabel, IonList, IonNote, IonPage, IonTitle, IonToolbar } from '@ionic/vue';
import { IonBadge, IonCheckbox, IonContent, IonFab, IonFabButton, IonHeader, IonIcon, IonItem, IonLabel, IonList, IonNote, IonPage, IonTitle, IonToolbar } from '@ionic/vue';
import { add } from 'ionicons/icons';
</script>
```
Expand Down Expand Up @@ -522,6 +524,7 @@ addIcons({
heart: heart,
});
```

**HomePage.vue**

```html
Expand Down