Skip to content

Conversation

@rdlabo
Copy link
Collaborator

@rdlabo rdlabo commented Oct 6, 2023

followed main branch

sean-perkins and others added 30 commits April 10, 2023 14:00
* fix(styles): add sidebar indentation for nested sections

* fix: spacing at end of sidebar

* fix: spacing between sections

* fix: padding between collapsed sections
* Update quickstart.md

this was set as intro to React Native which is wrong in my opinion. Should be Ionic React instead.

* Remove other incorrect references to React Native

---------

Co-authored-by: Shawn Taylor <[email protected]>
As providing index as keys is a bad practice, this commit modifies the key value to be `photo.filepath` which will be unique and consistent while adding new photos.

[Keys - react docs](https://reactjs.org/docs/lists-and-keys.html#keys)
[example why it is not recommended](https://robinpokorny.com/blog/index-as-a-key-is-an-anti-pattern/)
* docs(react): update firebase instructions for deploying pwa

---------

Co-authored-by: Brett Peary <[email protected]>
This link does not exist anymore as the migration guides are available as a top-level category in the sidebar.
# Conflicts:
#	docs/api/modal.md
#	docs/api/nav.md
#	docs/api/router-link.md
#	docs/api/searchbar.md
#	docs/api/select.md
#	docs/api/toast.md
#	docs/intro/next.md
#	docs/layout/structure.md
#	docs/react/lifecycle.md
#	docs/react/navigation.md
#	docs/react/overview.md
#	docs/react/pwa.md
#	docs/studio/setup/installation.md
#	docs/theming/css-shadow-parts.md
#	docs/vue/pwa.md
#	docs/vue/quickstart.md
#	versioned_docs/version-v6/studio.md
Co-authored-by: Greg Billetdeaux <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
renovate bot and others added 15 commits October 9, 2023 10:13
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore: release ionic 7.5 docs
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Conflicts:
#	docs/api/item.md
#	docs/api/label.md
#	docs/api/menu.md
#	docs/api/select.md
#	docs/api/toast.md
#	docs/layout/global-stylesheets.md
# Conflicts:
#	docs/api/datetime.md
#	docs/api/menu.md
#	docs/api/select.md
#	scripts/data/translated-api.json
#	scripts/data/translated-cache.json
#	scripts/data/translated-cli.json
#	src/components/global/Playground/index.tsx
#	src/translate/.detection/api/checkbox.json
#	src/translate/.detection/api/radio.json
#	src/translate/.detection/api/range.json
#	src/translate/.detection/api/router-outlet.json
#	src/translate/.detection/api/toggle.json
#	src/translate/api/checkbox.json
#	src/translate/api/radio.json
#	src/translate/api/range.json
#	src/translate/api/router-outlet.json
#	src/translate/api/toggle.json
#	static/usage/v7/alert/buttons/vue.md
#	static/usage/v7/theming/automatic-dark-mode/javascript.md
#	static/usage/v7/theming/manual-dark-mode/javascript.md
@rdlabo rdlabo merged commit 7229a94 into translation/jp Oct 17, 2023
@rdlabo rdlabo deleted the translation/jp-20231006 branch October 17, 2023 14:12
@liamdebeasi
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.