Skip to content

ioctl: add balance check when sending out any iotx (possibly check ga… #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

ioctl: add balance check when sending out any iotx (possibly check ga… #1302

merged 1 commit into from
Jun 24, 2019

Conversation

coderbradlee
Copy link
Contributor

…s fee too) 1299

work on #1299

@coderbradlee coderbradlee marked this pull request as ready for review June 22, 2019 06:04
@coderbradlee coderbradlee requested a review from a team as a code owner June 22, 2019 06:04
@coderbradlee coderbradlee requested review from guo and zjshen14 and removed request for a team June 22, 2019 06:04
zjshen14
zjshen14 approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@zjshen14 zjshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do this for the following too:

  1. Smart contract execution/deployment
  2. XRC20 token transfer

You could do them in separate PRs.

@coderbradlee coderbradlee merged commit f64a6dd into iotexproject:master Jun 24, 2019
@coderbradlee coderbradlee mentioned this pull request Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjshen14 zjshen14 zjshen14 approved these changes

@guo guo Awaiting requested review from guo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coderbradlee @zjshen14