Dont use startForegroundService() for just dimissing a connection #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rex-iotum
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids attempting to start the service in the foreground in the case where were just telling MyConnectionService to dismiss the call. (since in this case we won't actually be calling this.startForegound there).
The UX is currently is not broken, call is dismissed but noticed this error in the LogCat, and its easy to avoid/address this.
Note: calling startForegroundService requires a timely call to startForeground (internally in MyConnectionServie) which will only happen if were actually creating an IncomingConnection, launching the notification etc.