Skip to content

Grammar issues fix #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Grammar issues fix #1445

merged 2 commits into from
Oct 13, 2019

Conversation

sudhirkumarojhaa
Copy link
Contributor

Made some changes to make it more correct.

Made some changes to make it more correct.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iliakan
Copy link
Member

iliakan commented Oct 13, 2019

Looks wrong to me, but let @paroche decide.

@iliakan iliakan merged commit 5899172 into javascript-tutorial:master Oct 13, 2019
@iliakan
Copy link
Member

iliakan commented Oct 13, 2019

Thanks!

@iliakan
Copy link
Member

iliakan commented Oct 13, 2019

@paroche Please review =)
Is "each one equipped with its own bells and whistles." better than "each one with its own bells and whistles." ?

@paroche
Copy link
Collaborator

paroche commented Oct 14, 2019

I think it's better without "equipped". Could even leave out "one", as below:

There exist many frameworks and development methodologies to build them, each with its own bells and whistles. Usually, special CSS classes and conventions are used to provide "component feel" -- CSS scoping and DOM encapsulation.

There is a slight awkwardness about the way it reads, though. Could perhaps rephrase:
"..., and each one has its own bells and whistles." But it's not a big deal.

@iliakan
Copy link
Member

iliakan commented Oct 14, 2019

Thank you! Changed the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants