Skip to content

minor #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2019
Merged

minor #1482

merged 1 commit into from
Oct 19, 2019

Conversation

Darryl1702
Copy link
Contributor

No description provided.

@iliakan iliakan requested a review from paroche October 19, 2019 17:21
@iliakan
Copy link
Member

iliakan commented Oct 19, 2019

@paroche should I put an article before attributeName?

@paroche
Copy link
Collaborator

paroche commented Oct 19, 2019

If you mean the event names as in the patch here, then yes -- the several changes by Ghost-017 in patch-4 look right to me. Was that what you meant?

(Only the insertion of "for this" seems optional , i.e. "The reason" works OK by itself, but it is just a little better with "for this" following it).

@iliakan
Copy link
Member

iliakan commented Oct 19, 2019

Yes, all these changes are correct? Including "the" before event names?

I guess, my article skills are far from perfect 🤷‍♂

@paroche
Copy link
Collaborator

paroche commented Oct 19, 2019

Yes, they read better with all the "the"s. As you may know, it is a stereotype of a native Russian-speaker speaking English that they leave out articles (and the occasional preposition): "Need go now -- must feed cat and dog!" Perfectly understandable, but should have "to" and at least one "the" or "my" or something (unless you have a cat named "cat" and a dog named "dog"). But I think you usually get it right. And almost all writers can use help proofing and copy editing, even native speakers.

@paroche paroche merged commit 4088e5d into javascript-tutorial:master Oct 19, 2019
@paroche
Copy link
Collaborator

paroche commented Oct 20, 2019

It had me down as a pending reviewer, though I thought I had already reviewed it. So I did the merge to get it to shut up. Hope that was OK.

@iliakan
Copy link
Member

iliakan commented Oct 20, 2019

Sure, you're totally right about articles =).

I just wanted to ask, whether or not the list might be an exception?

  • unload event..
  • load event..
    ...

It's easier to read when list items start with the an event name, rather than the "The" article.

Or not? So the question is specifically list-related.

@paroche
Copy link
Collaborator

paroche commented Oct 20, 2019

Revised answer:

It depends on the context. Some examples:

If you are using the singular, as in your partial example, you would probably only want to leave out "the" if you were not making the element the subject of the sentence. E.g.:

Not so good:

  • `unload event` is fired when the document or a child resource is being unloaded.
  • Fine:

  • The `unload` event is fired... (this is straight from MSN)
  • However,

  • `unload` events fire when...
  • would be OK. (because it's plural).

    I think it works something like this:

    Categories of things, like "unload events", don't require an article.

    Neither do particular named things, like "that listener that we call 'myEventListener`:

  • 'myEventListener` is triggered when...'
  • But generic examples of a type of thing do:

    Bad:

  • `listener` function listens for events...
  • Good:

  • The `listener` function listens for events...
  • Or, also good:

  • `myListenerFunction` listens for events.
  • This is applies whether they are in a list or not.

    BUT, if we are not making the item the actual subject of the sentence using a verb, i.e. if it were more like this:

  • `unload event`: fires when the document...
  • `load event`: fires when the document is being loaded
  • Then is good as shown -- no article needed (or wanted). Since this kind of formatting is common in lists, I think maybe that may be at least part of what you're talking about.

    So it's more the grammatical structure of the list element that makes the difference, not the fact of it being in a list per se.

    I think. Unless I see a counter example.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants