Export and import #121

anapaulalemos · 2020-05-07T01:45:12Z

No description provided.

CLAassistant · 2020-05-07T01:45:16Z

All committers have signed the CLA.

wnleao · 2020-05-09T15:55:17Z

Hey, Ana! Could you join all commits in only 1?

wnleao · 2020-05-09T15:56:25Z

Btw, did you check if the english version had changes? Some pt-br articles are way back... https://github.com/javascript-tutorial/en.javascript.info

anapaulalemos · 2020-05-09T16:51:46Z

Hey, Ana! Could you join all commits in only 1?

Of course! No problem.

Btw, did you check if the english version had changes? Some pt-br articles are way back... https://github.com/javascript-tutorial/en.javascript.info

I didn't, to be honest. But I'll check that and the above comment and return, okay?

wnleao · 2020-05-09T17:44:34Z

Hey, Ana! Could you join all commits in only 1?

Of course! No problem.

Btw, did you check if the english version had changes? Some pt-br articles are way back... https://github.com/javascript-tutorial/en.javascript.info

I didn't, to be honest. But I'll check that and the above comment and return, okay?

No problem! Let me know when you're done and I'll review your PR.

anapaulalemos · 2020-05-09T18:21:48Z

No problem! Let me know when you're done and I'll review your PR.

It's done. Thank you!

wnleao · 2020-05-09T18:35:57Z

No problem! Let me know when you're done and I'll review your PR.

It's done. Thank you!

Right! I'll review it. Wouldn't you like to become a maintainer? Ask iliakan in an issue in the main repository and he will grant you permission.

wnleao · 2020-05-09T18:45:15Z

Ana, in your commit there is a change to 1-js/01-getting-started/2-manuals-and-specifications/article.md → 1-js/01-getting-started/2-manuals-specifications/article.md. Could you remove it? I think you added it by mistake.

wnleao · 2020-05-09T18:56:31Z

1-js/13-modules/02-import-export/article.md


-# Export and Import
+As diretivas Export e import tem diversas variantes de sintaxe.


Could we leave export in lowercase aswell?

wnleao · 2020-05-09T19:00:58Z

1-js/13-modules/02-import-export/article.md

    ```
-    ...Then the optimizer will automatically detect it and totally remove the other functions from the bundled code, thus making the build smaller. That is called "tree-shaking".
+    ...Então o otimizador vai ver isso e remover as outras funções nã utilizadas nó código, tornando o build menor. Isso é chamado de "tree-shaking".


There're two minor typos "nã" and "nó" código.

wnleao · 2020-05-09T19:02:44Z

1-js/13-modules/02-import-export/article.md

    ```
-    ...Then the optimizer will automatically detect it and totally remove the other functions from the bundled code, thus making the build smaller. That is called "tree-shaking".
+    ...Então o otimizador vai ver isso e remover as outras funções nã utilizadas nó código, tornando o build menor. Isso é chamado de "tree-shaking".


Missing the "from the bundled code" part.

wnleao · 2020-05-09T19:04:39Z

1-js/13-modules/02-import-export/article.md

-2. Explicitly listing what to import gives shorter names: `sayHi()` instead of `lib.sayHi()`.
-3. Explicit imports give better overview of the code structure: what is used and where. It makes code support and refactoring easier.
+2. Listar explicitamente o que importar nos fornece nomes mais curtos: `sayHi()` ao invés de `say.sayHi()`.
+3. Uma lista explícita do que importar fornecem uma visão geral melhor da estrutura do código: o que é usado e onde. Torna o código fácil de prover suporte e de refatorar.


Minor typo: "Uma lista ... fornece" and not "fornecem".

wnleao · 2020-05-09T19:14:05Z

1-js/13-modules/02-import-export/article.md


 new User('John');
 ```

-Imports without curly braces look nicer. A common mistake when starting to use modules is to forget curly braces at all. So, remember, `import` needs curly braces for named imports and doesn't need them for the default one.
+Imports sem chaves parecem mais agradáveis. Um erro comum quando se começa a usar módulos é esquecer das chaves. Então, lembre-se, `import` precisa de chaves para import nomeados e não precisa para os imports default.


I believe it would be better to use "imports nomeados (named imports)". What do you think?

I agree with that.

wnleao · 2020-05-09T19:24:33Z

1-js/13-modules/02-import-export/article.md


-Usually, to avoid that and keep the code consistent, there's a rule that imported variables should correspond to file names, e.g:
+Geralmente, para evitar isso e manter o código consistente, existe uma regra que as variáveis importadas deve corresponder ao nome dos arquivos, por exemplo:


minor typo: "variáveis importadas deve" -> "variáveis importadas devem"

wnleao · 2020-05-09T19:25:41Z

1-js/13-modules/02-import-export/article.md

@@ -306,133 +305,152 @@ import func from '/path/to/func.js';
 ...
 ```

-Another solution would be to use named exports everywhere. Even if only a single thing is exported, it's still exported under a name, without `default`.
+Ainda assim, algumas equipes consideram isso uma séria desvantagem dos exports default. Então, eles preferem usar sempre exports com nomes. Mesmo se apenas uma coisa é exportada, ele ainda será exportada com um nome, sem `default`.


should it not be "ela ainda será" ?

wnleao · 2020-05-09T19:29:36Z

1-js/13-modules/02-import-export/article.md


-Now, as the actual exported functionality is scattered among the package, we can gather and "re-export" it in `auth/index.js`:
+Como as funcionalidade exportadas estão espalhadas pelo pacote, podemos importá-las em `auth / index.js` e exportá-las neles:


minor typo: "exportá-las neles" -> "exportá-las nele"

1-js/13-modules/02-import-export/article.md

wnleao · 2020-05-09T19:41:30Z

1-js/13-modules/02-import-export/article.md

 }
 ```

-...But what if we really need to import something conditionally? Or at the right time? Like, load a module upon request, when it's really needed?
+... Mas e se realmente precisarmos importar algo condicionalmente? Ou na hora certa? Como carregar um módulo mediante solicitação, quando é realmente necessário?


I think you missed a comma after "Como". With a comma, the following becomes an example rather than a question How.

javascript-translate-bot · 2020-05-09T19:42:16Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

anapaulalemos · 2020-05-10T00:01:03Z

/done

wnleao · 2020-05-10T02:46:50Z

Great! Nice work :) could you review a quick one: #122 I just added a missing article from the english version. And also, could you review #120 ? Thank you!

anapaulalemos · 2020-05-10T13:02:22Z

Great! Nice work :) could you review a quick one: #122 I just added a missing article from the english version. And also, could you review #120 ? Thank you!

Thank you! And, for sure, I'll take a look at both :)

wnleao · 2020-05-11T21:48:17Z

1-js/13-modules/02-import-export/article.md


-# Export and Import
+As diretivas export e import tem diversas variantes de sintaxe.


sorry, Ana, I missed this one: "As diretivas ... têm" <- circumflex

javascript-translate-bot · 2020-05-11T21:48:27Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

anapaulalemos · 2020-05-13T22:46:00Z

/done

javascript-translate-bot added the review needed label May 7, 2020

javascript-translate-bot requested a review from a team May 7, 2020 01:45

wnleao requested changes May 9, 2020

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels May 9, 2020

javascript-translate-bot added review needed and removed changes requested labels May 10, 2020

javascript-translate-bot requested a review from a team May 10, 2020 00:01

wnleao approved these changes May 10, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels May 10, 2020

wnleao mentioned this pull request May 10, 2020

Iterables #118

Closed

wnleao requested changes May 11, 2020

View reviewed changes

javascript-translate-bot added the changes requested label May 11, 2020

squashing all commits

2b98bfe

javascript-translate-bot removed the changes requested label May 13, 2020

javascript-translate-bot added the review needed label May 13, 2020

javascript-translate-bot requested a review from a team May 13, 2020 22:46

iliakan mentioned this pull request May 13, 2020

Portuguese Translation Progress #1

Open

wnleao approved these changes May 13, 2020

View reviewed changes

wnleao merged commit 817a0f1 into javascript-tutorial:master May 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export and import #121

Export and import #121

anapaulalemos commented May 7, 2020

CLAassistant commented May 7, 2020 •

edited

Loading

wnleao commented May 9, 2020 •

edited

Loading

wnleao commented May 9, 2020 •

edited

Loading

anapaulalemos commented May 9, 2020 •

edited

Loading

wnleao commented May 9, 2020

anapaulalemos commented May 9, 2020

wnleao commented May 9, 2020 •

edited

Loading

wnleao commented May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

anapaulalemos May 10, 2020

wnleao May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

wnleao May 9, 2020

javascript-translate-bot commented May 9, 2020

anapaulalemos commented May 10, 2020

wnleao commented May 10, 2020

anapaulalemos commented May 10, 2020

wnleao May 11, 2020

javascript-translate-bot commented May 11, 2020

anapaulalemos commented May 13, 2020


		# Export and Import
		As diretivas Export e import tem diversas variantes de sintaxe.


		Usually, to avoid that and keep the code consistent, there's a rule that imported variables should correspond to file names, e.g:
		Geralmente, para evitar isso e manter o código consistente, existe uma regra que as variáveis importadas deve corresponder ao nome dos arquivos, por exemplo:


		Now, as the actual exported functionality is scattered among the package, we can gather and "re-export" it in `auth/index.js`:
		Como as funcionalidade exportadas estão espalhadas pelo pacote, podemos importá-las em `auth / index.js` e exportá-las neles:

Export and import #121

Export and import #121

Conversation

anapaulalemos commented May 7, 2020

CLAassistant commented May 7, 2020 • edited Loading

wnleao commented May 9, 2020 • edited Loading

wnleao commented May 9, 2020 • edited Loading

anapaulalemos commented May 9, 2020 • edited Loading

wnleao commented May 9, 2020

anapaulalemos commented May 9, 2020

wnleao commented May 9, 2020 • edited Loading

wnleao commented May 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javascript-translate-bot commented May 9, 2020

anapaulalemos commented May 10, 2020

wnleao commented May 10, 2020

anapaulalemos commented May 10, 2020

Choose a reason for hiding this comment

javascript-translate-bot commented May 11, 2020

anapaulalemos commented May 13, 2020

CLAassistant commented May 7, 2020 •

edited

Loading

wnleao commented May 9, 2020 •

edited

Loading

wnleao commented May 9, 2020 •

edited

Loading

anapaulalemos commented May 9, 2020 •

edited

Loading

wnleao commented May 9, 2020 •

edited

Loading