-
Notifications
You must be signed in to change notification settings - Fork 113
Type Conversions #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Conversions #212
Conversation
Translated 1-js/02-first-steps/07-type-conversions/article.md
I hadn't translated a table on last commit
Translated "any non-empty string becomes true"
Hi @PauloBacelar , this topic is assigned to @mrodrigochaves . |
Hello, @odsantos. The article is fully translated. When I translated it, I didn't know about the existence of this issue, so I didn't assign the topic to myself. If @mrodrigochaves translated, you can use his translation. Otherwise, feel free to use mine. When I get some free time I'll translate some other articles. |
Hi @PauloBacelar , if I do not get a response from @mrodrigochaves in a couple of days I'll assign this topic to you, and then if you don't mind I'll ask you to add his translations to yours since he already translated two files on a subfolder. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PauloBacelar,
Here is my review. Please, feel free to comment where you disagree.
Thank you.
Please make the requested changes. After it, add a comment "/done". |
Thanks for reviewing. Tomorrow I'll commit your changes to the file |
Thank you. |
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
Co-authored-by: Osvaldo Dias dos Santos <[email protected]>
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PauloBacelar,
Following the rules, we now need a second maintainer to review your translation.
Thank you.
Great translation ❤️ I'm reading each article on the platform to evolve with the translation to the PT language and terms the url with published subdomain, as it exists in other languages already fully translated: see #1 (comment) in the progress edit. Considering that the translation of this article contemplates this open PR, I would like to know if I have permission here to leave my review note or if I can contribute in some other way to the evolution of this edition?
From the translation, I identified two points of correction (as previously commented) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @PauloBacelar
Could you correct the quoted comments, please?
Please make the requested changes. After it, add a comment "/done". |
/done |
Error: the article already translated in the Progress Issue #1 |
@PauloBacelar ... we appreciate the collaboration ⭐ |
No description provided.