Skip to content

Type Conversions #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jun 29, 2022
Merged

Type Conversions #212

merged 33 commits into from
Jun 29, 2022

Conversation

PauloBacelar
Copy link
Contributor

No description provided.

Translated 1-js/02-first-steps/07-type-conversions/article.md
I hadn't translated a table on last commit
Translated "any non-empty string becomes true"
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2021

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor

Hi @PauloBacelar , this topic is assigned to @mrodrigochaves .
Did you translate the whole article? Thank you.

@PauloBacelar
Copy link
Contributor Author

PauloBacelar commented Jul 16, 2021

Hi @PauloBacelar , this topic is assigned to @mrodrigochaves .
Did you translate the whole article? Thank you.

Hello, @odsantos.

The article is fully translated. When I translated it, I didn't know about the existence of this issue, so I didn't assign the topic to myself.

If @mrodrigochaves translated, you can use his translation. Otherwise, feel free to use mine. When I get some free time I'll translate some other articles.

@odsantos
Copy link
Contributor

Hi @PauloBacelar , if I do not get a response from @mrodrigochaves in a couple of days I'll assign this topic to you, and then if you don't mind I'll ask you to add his translations to yours since he already translated two files on a subfolder.

Thank you.

@odsantos odsantos changed the title Translated article "Type Conversion" Type Conversions Jul 19, 2021
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PauloBacelar,

Here is my review. Please, feel free to comment where you disagree.
Thank you.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@PauloBacelar
Copy link
Contributor Author

Hi @PauloBacelar,

Here is my review. Please, feel free to comment where you disagree.
Thank you.

Thanks for reviewing. Tomorrow I'll commit your changes to the file

@odsantos
Copy link
Contributor

Hi @PauloBacelar,
Here is my review. Please, feel free to comment where you disagree.
Thank you.

Thanks for reviewing. Tomorrow I'll commit your changes to the file

Thank you.

@PauloBacelar
Copy link
Contributor Author

/done

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PauloBacelar,

Following the rules, we now need a second maintainer to review your translation.

Thank you.

@jonnathan-ls
Copy link
Contributor

@PauloBacelar

Great translation ❤️

@odsantos

I'm reading each article on the platform to evolve with the translation to the PT language and terms the url with published subdomain, as it exists in other languages ​​already fully translated: see #1 (comment) in the progress edit.

Considering that the translation of this article contemplates this open PR, I would like to know if I have permission here to leave my review note or if I can contribute in some other way to the evolution of this edition?

This PR has been open for over 1 year.

From the translation, I identified two points of correction (as previously commented)

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PauloBacelar

Could you correct the quoted comments, please?

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@PauloBacelar
Copy link
Contributor Author

/done

@jonnathan-ls jonnathan-ls merged commit 959db73 into javascript-tutorial:master Jun 29, 2022
@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

@jonnathan-ls
Copy link
Contributor

@PauloBacelar ... we appreciate the collaboration ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants