-
Notifications
You must be signed in to change notification settings - Fork 113
Anchors: string start ^ and end $ #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I review your changes, they are good in general, but there are some changes I would like you to look.
Please make the requested changes. After it, add a comment "/done". |
These seem pretty reasonable, I'll get to it later today. Thanks for the review Nazaré! |
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems acceptable to me, so let's see what others maintainers have to say.
@jonnathan-ls Looks good to me! Thanks for fishing up the remaining bits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tomei a liberdade de traduzir o restante de trechos em ingles, conforme commit (56d7f23), tudo bem pra ti a alteração?
Com isso, está LGTM (Looks Good To Me) ...
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
@jonnathan-ls Tranquilo! Vou passar a traduzir esses trechos daqui em diante também. Obrigado pela força 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peruibeloko, well done, we are moving forward finally. We have some more few pull requests to review.
Usarei os termos "casar", "casamento" e "correspondência" como tradução para "match" dependendo do contexto, mas quero evitar usar outros termos para evitar confusões.
No artigo como um todo, mas específicamente no trecho
Faltou com uma explicação simples do que as âncoras realmente representam: uma posição, que foi o que adicionei na minha tradução: