Skip to content

fix: join方法描述缺失 #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2024
Merged

fix: join方法描述缺失 #1182

merged 2 commits into from
Jan 26, 2024

Conversation

NansenHo
Copy link
Contributor

目标章节：1-js/05-data-types/05-array-methods

当前上游最新 commit：无

本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 无 补全缺失的 join 方法描述

@javascript-translate-bot javascript-translate-bot requested a review from a team October 24, 2023 02:36
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

leviding
leviding reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数组改为数组项，是否会更好一些

@leviding leviding added question Further information is requested and removed review needed labels Jan 21, 2024
@leviding leviding merged commit 0db559b into javascript-tutorial:master Jan 26, 2024
@leviding
Copy link
Member

Thanks a lot. The pull request has been merged.

@leviding leviding added DONE and removed question Further information is requested labels Jan 26, 2024
@NansenHo
Copy link
Contributor Author

数组改为数组项，是否会更好一些

不好意思啊，才看到消息。

@leviding
Copy link
Member

数组改为数组项，是否会更好一些

不好意思啊，才看到消息。

哈哈，没事，谢谢贡献。你看我调整的是否可以，不行的话可以继续修改。我着急就合并了 🤣

@NansenHo NansenHo deleted the fix-join方法描述缺失 branch January 30, 2024 02:43
@NansenHo
Copy link
Contributor Author

数组改为数组项，是否会更好一些

不好意思啊，才看到消息。

哈哈，没事，谢谢贡献。你看我调整的是否可以，不行的话可以继续修改。我着急就合并了 🤣

完美，感谢调整！😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviding leviding leviding left review comments

Assignees
No one assigned
Labels
DONE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NansenHo @CLAassistant @leviding @javascript-translate-bot