Fix server-side out of order ajax responses #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n draw (counter) parameter.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With server-side rendering if multiple concurrent ajax requests return out of order, a previous ajax response could end up overwriting (on the client side) a later response. Ajax datatables has a builtin solution for this. It passes a draw parameter which serves as a version (it's just a counter). If an ajax response is from a version prior to what is currently being displayed, then the result is ignored. The draw parameter is expected to be returned (casted as an integer to prevent XSS attacks) as specified by Ajax datatables here - https://datatables.net/manual/server-side#Returned-data
This PR will offer an immediate fix for out of order response rendering for all default configurations of ajax-datatables-rails.