Add React Hot Reload #126
Merged
Add React Hot Reload #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaljsr
commented
Dec 31, 2018
| )(Routes); | ||
|
|
||
| export default withRouter(ConnectedRoutes); | ||
| export default withRouter(hot(ConnectedRoutes)); |
Collaborator
Author
There was a problem hiding this comment.
Just a note, the hot() function is essentially a NOOP in production builds
See https://github.com/gaearon/react-hot-loader/blob/master/root.js
Collaborator
Author
|
Confirmed working in Chrome, Firefox & Brave. This PR is ready, awaiting feedback. |
Member
|
Sorry for the delay, have had some computer issues that have kept me away from Joule for the last week. I'll be able to test & merge this tomorrow. |
wbobeirne
approved these changes
Jan 7, 2019
Member
wbobeirne
left a comment
wbobeirne
left a comment
There was a problem hiding this comment.
This works great, and will be a huge boon to productivity. Thanks for taking a crack at it. There's probably a lot that can be done to improve the incremental builds (my machine was getting ~5s per build) but we can merge as-is, and improve that later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
Description
Adds React Hot Reload functionality to the development environment. No modifications are made to production builds. This simply improves the feedback loop of seeing changes
Steps to Test
yarn run hotNotes
This is not 100% ready to be merged, but I wanted to put it out there for now. I need to test browsers other than Chrome to make sure nothing is broken.