Skip to content

Conversation

@wbobeirne
Copy link
Member

Closes #206

Description

Fixes some payments (I think only quite old ones) from crashing the transactions tab. This happened due to them coming back with undefined paths. In total, this PR does the following:

  • Defaults the path array to [] if undefined
  • Improves the display of pathless payments
  • Improves the Identicon component by having it display a (?) when the pubkey is falsy

Steps to Test

  1. Get a pathless payment, or alter the code so that you can forcefully induce one
  2. Load the transactions tab, confirm it doesn't crash
  3. Open a pathless transaction, confirm it displays correctly

Screenshots

List view

Screen Shot 2019-04-24 at 2 26 18 PM

Detail view

Screen Shot 2019-04-24 at 2 28 40 PM

@wbobeirne
Copy link
Member Author

Confirmed working here: #206 (comment)

Merging in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transactions tab crashes for some nodes

2 participants