Sync warning #209
Merged
Sync warning #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Verified. Nice work!
|
Member
Author
|
Excellent, thanks for giving it a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199
Description
Adds a banner when your node is still syncing to the chain to let you know that your balances might be off. To my knowledge there's no way to get progress, since it always reports the bitcoin node's block height, not LND's current scan progress, so the best we can do is this boolean display.
Steps to Test
Open joule with a syncing node (or induce the state yourself programmatically), confirm you see a banner.
Screenshots