Skip to content

Conversation

@wbobeirne
Copy link
Member

Closes #227

Description

Changes prompt errors from message.error which would disappear automatically, to rendering an <Alert /> that the user has to manually dismiss. Doesn't look quite as nice, but should be a lot better for longer errors or when the user backgrounds the window and comes back later.

Steps to Test

  1. Go to https://webln.dev/#/api/make-invoice
  2. Make an invoice of a number way too high
  3. Confirm you get an error
  4. Confirm the error doesn't disappear automatically
  5. Confirm clicking on the X dismisses the error

Screenshots

Screen Shot 2019-09-15 at 12 10 23 PM

@wbobeirne wbobeirne merged commit cf0ffd0 into develop Sep 15, 2019
@wbobeirne wbobeirne deleted the better-prompt-errors branch September 15, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors disappear too quickly

2 participants