BTCPay Server onboarding #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome: Though can you do this: In the configuration file, right now you can find the Can you, in your code consider that if That way, when I update BTCPay it will properly use the right one. |
| private handleBTCPayServerConfig = (config: BTCPayServerConfig) => { | ||
| const macaroons = { | ||
| adminMacaroon: config.macaroon, | ||
| readonlyMacaroon: config.restrictedMacaroon || config.macaroon, |
There was a problem hiding this comment.
use readonlyMacaroon instead of restrictedMacaroon
|
Ah actually you do this, just rename |
Member
Author
|
Thanks for that, the change has been made. I'll be merging shortly. |
wbobeirne
pushed a commit
that referenced
this pull request
Oct 13, 2020
…/typescript-3.9.6 Update typescript: 3.9.3 → 3.9.6 (patch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79. Will want a review from @NicolasDorier on this one.
Description
Adds an option to the node selector for BTCPay Server. Uses the BTCPay Server config format for filling out URI & macaroons.
Steps to Test
Screenshots
^Click to embiggen