Remove a useless instruction #8418
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
Build is broken because of an HTTP issue when setting up the environment. |
|
@Hywan Are you willing to update your PR according to latest master? |
|
|
|
nope, it still has it https://github.com/jquery/jquery-mobile/blob/master/js/widgets/forms/select.js#L259 |
|
@apsdehal Done 😃. |
The `text` variable is first initialized to `this.placeholder`, which is strictly equivalent to use `that.placeholder` inside the function used just after. So in case `selected.length` is falsy, this is not necessary to override `text` to the same value, i.e. its inital value.
|
Thanks :-). |
The
textvariable is first initialized tothis.placeholder, which is strictly equivalent to useself.placeholderinside the function used just after. So in caseselected.lengthis falsy, this is not necessary to overridetextto the same value, i.e. its inital value.Also fix a CS.