This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Controlgroup height and default font-family #8516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents 1px extra height of input buttons on Firefox
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons: Use margin instead of bottom offset for vertical icon position - This makes sure the buttons inside a controlgroup all have the same height, no matter what font is used, and floating icons (selectmenu button) and inline icons have the same vertical position.
Core: Also unset moz-focus-inner border for input elements - Same as we did for buttons on firefox needs to be done for input buttons to prevent them being 1px higher than other buttons inside a controlgroup.
Theme: Set system font as default font - See #8503 (comment)