Fix mark deactivation timing in gptel-rewrite #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gptel-rewrite.el (gptel--suffix-rewrite): Postpone deactivate-mark to prevent "The mark is not active now" error when `mark-even-if-inactive' is nil.
|
@ultronozm Thanks for the PR! |
karthink
pushed a commit
to pirminj/gptel
that referenced
this pull request
Jan 27, 2025
gptel-rewrite.el (gptel--suffix-rewrite): Postpone deactivate-mark to prevent "The mark is not active now" error when `mark-even-if-inactive' is nil.
marcbowes
pushed a commit
to marcbowes/gptel
that referenced
this pull request
Mar 19, 2025
gptel-rewrite.el (gptel--suffix-rewrite): Postpone deactivate-mark to prevent "The mark is not active now" error when `mark-even-if-inactive' is nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce: using gptel-rewrite with mark-even-if-inactive set
to nil (and tmm enabled) yields the error "The mark is not active now".
to prevent "The mark is not active now" error when
`mark-even-if-inactive' is nil.