elpaignore: Add .github #699
Conversation
Ignore .github (and .elpaignore itself) from ELPA releases.
|
ELPA does not exclude the . I'm not sure whether the ELPA team sees this as an issue or an intended part of the design. Should we discuss it on emacs-devel?
It does not directly. But since ELPA and MELPA have the opposite logic, right now gptel installed from ELPA includes documentation files, while MELPA only contain If we aim for identicality, we'd either have to drop the documentation with in (I am probably just dumb, but I don't know where to find the |
|
ELPA does not exclude the .`elpaignore` file itself from the package tarballs. Many projects (but definedly not all) seem to include it in `.elpaignore`. I just verified that installing v0.9.7 from elpa.nongnu.org does indeed leave the file under `.emacs.d/elpa/gptel-0.9.7`, so it is not striped during installing.
Ah, okay. Thanks for the clarification.
I'm not sure whether the ELPA team sees this as an issue or an intended part of the design. Should we discuss it on emacs-devel?
Maybe we can seek some quick verification from Philip Kaludercic that this is okay to add .elpaignore to .elpaignore? Unless you are sure that it's okay, then I'll take your word for it.
> * I didn't understand how this PR relates to what MELPA includes or doesn't include.
It does not directly. But since ELPA and MELPA have the opposite logic, right now gptel installed from ELPA includes documentation files, while MELPA only contain `.el` files.
If we aim for identicality, we'd either have to drop the documentation with in `.elpaignore` or adjust the MELPA recipe to include them. However, MELPA advises against including additional files, a "cultural difference" we likely want to observe. In ELPA, it's common to include, however `LICENSE` and `COPYING` (etc) are mostly listed as `:ignored-files`.
I don't think we need to aim for identical installs.
(I am probably just dumb, but I don't know where to find the `elpa-packages` file for nongnu, is it on a separate git repo or some branch?)
I don't know what you mean by the "elpa-packages file". My only point of connection with nongnu-elpa is this page: https://elpa.nongnu.org/nongnu/gptel.html
|
To be honest, I never even imagined I could be anything but dumb. The repo is of course in git.savannah and here is the relevant part for gptel in (gptel :url "https://github.com/karthink/gptel"
:readme ignore)I agree that ignoring the README file is a good idea, since the commentary section in |
And to clarify, |
Well at least it should be safe and not break anything, since e.g. transient is doing it: https://github.com/magit/transient/blob/main/.elpaignore It seems that including |
Works for me! |
See upstream for individual commits. 748fd85 gptel: Remove nosystem capability for o1/o3 models (karthink#702) 7de8e88 gptel-curl: Add gptel-curl-extra-args 4c5f7e6 gptel: Bump version to v0.9.8 2835d93 gptel: Remove obsolete variables, update NEWS cc3d74d gptel-org: Obey gptel-org settings when sending regions 8a289e9 gptel-transient: Return to menu with just RET (karthink#695) 9245dfd elpaignore: Add .github (karthink#699) 10e7739 gptel-transient: Don't serialize backend to transient history e77a47b NEWS: Use org comment and fill paragraphs (karthink#696) d9edbbc NEWS: Add news file 85a3c00 test: Update submodule 6320c2b gptel: Use font-lock-flush instead of font-lock-fontify-region 7400df6 gptel: Create all prompts in temp buffer aef57c2 gptel-openai-extras: Fix Deepseek repeated roles error 8889e27 gptel-rewrite: Ignore reasoning output correctly 4edf81c gptel: Linting 354829b test: Update for gptel-org-ignore-elements b7eb4fc gptel-org: Strip property drawers from the prompt 4ca50d7 gptel-anthropic: Fix reasoning parsing bug d9ce451 gptel-anthropic: Add prompt caching (karthink#355) c23cba5 gptel: Add blocks around reasoning content 6de3e00 gptel: Change how reasoning content is tracked 44f75b7 gptel-transient: Fix key collision in gptel-menu 95eefe4 gptel-org: Fix typo from refactoring 8e0d682 gptel-openai: Fix collision with openrouter parsing (karthink#669) 0a2fcb9 gptel-curl: Handle end of reasoning stream in other buffer 3963aff gptel-org: Use gptel-org- prefix consistently
.elpaignore: Ignore .github (and .elpaignore itself) from ELPA releases.
2 participants
Just some minor finishing touch before 0.9.8 release to elpa.nongu.org.
MELPA does not include documentation (
README.org,NEWS,LICENSE) by default, unlike (non-)GNUELPA. But IMHO they are useful (and not litter, like.github/ISSUE_TEMPLATE) and consume tiny amount of disk space, so I don't see a reason to exclude them.