gptel-rewrite: Diff buffers, not files #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pabl0
commented
Mar 22, 2025
pabl0
commented
- gptel-rewrite.el (gptel--rewrite-diff): Show the difference between buffers rather than file names. Otherwise, if a) the buffer has never been saved, the error "No such file or directory" will occur, or b) if there are unsaved changes in the buffer, the diff output will not reflect those changes.
* gptel-rewrite.el (gptel--rewrite-diff): Show the difference between buffers rather than file names. Otherwise, if a) the buffer has never been saved, the error "No such file or directory" will occur, or b) if there are unsaved changes in the buffer, the diff output will not reflect those changes.
|
Thanks @pabl0! I don't remember why I set it up to look for a file -- it was definitely deliberate considering the trouble I went to there instead of just calling |
1 task
aagit
added a commit
to aagit/gptel
that referenced
this pull request
Oct 9, 2025
This reverts commit 0ce917a. The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff. Signed-off-by: Andrea Arcangeli <[email protected]>
aagit
added a commit
to aagit/gptel
that referenced
this pull request
Oct 9, 2025
This reverts commit 0ce917a. The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff.
aagit
added a commit
to aagit/gptel
that referenced
this pull request
Oct 9, 2025
This reverts commit 0ce917a. The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff.
aagit
added a commit
to aagit/gptel
that referenced
this pull request
Oct 15, 2025
This reverts commit 0ce917a. The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.