Skip to content

gptel-bedrock: Plumb request-params all the way through #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

gptel-bedrock: Plumb request-params all the way through #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions gptel-bedrock.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,22 @@

(cl-defmethod gptel--request-data ((backend gptel-bedrock) prompts)
"Prepare request data for AWS Bedrock BACKEND from PROMPTS."
(nconc
`(:messages [,@prompts] :inferenceConfig (:maxTokens ,(or gptel-max-tokens 500)))
(when gptel--system-message `(:system [(:text ,gptel--system-message)]))
(when gptel-temperature `(:temperature ,gptel-temperature))
(when (and gptel-use-tools gptel-tools)
`(:toolConfig (:toolChoice ,(if (eq gptel-use-tools 'force) '(:any '()) '(:auto '()))
:tools ,(gptel--parse-tools backend gptel-tools))))))
;; First, build the core Bedrock request data structure.
(let ((base-request-data
(nconc
`(:messages [,@prompts] :inferenceConfig (:maxTokens ,(or gptel-max-tokens 500)))
(when gptel--system-message `(:system [(:text ,gptel--system-message)]))
(when gptel-temperature `(:temperature ,gptel-temperature))
(when (and gptel-use-tools gptel-tools)
`(:toolConfig (:toolChoice ,(if (eq gptel-use-tools 'force) '(:any '()) '(:auto '()))
:tools ,(gptel--parse-tools backend gptel-tools)))))))

;; Finally, merge all potential :request-params sources.
(gptel--merge-plists
base-request-data ; The core data we just built
gptel--request-params ; Global/buffer-local gptel--request-params
(gptel-backend-request-params backend) ; From `gptel-make-bedrock` call
(gptel--model-request-params gptel-model)))) ; From the model's properties

(cl-defmethod gptel--parse-tools ((_backend gptel-bedrock) tools)
"Parse TOOLS and return a list of ToolSpecification objects.
Expand Down