-
Couldn't load subscription status.
- Fork 17
🐛 Fix groupnames in examples #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
…orking, include it in `make test` On-behalf-of: @SAP [email protected]
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 78b6b39ddaa4f307ef7c0aa378366b3d12bc23f0
|
|
/lgtm |
|
All good @mjudeikis , thanks @xrstf ! |
|
/hold cancel |
|
/cherrypick kcp-1.32.3 |
|
@xrstf: new pull request created: #103 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick kcp-1.31.6 |
|
@xrstf: new pull request created: #104 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
I am not sure why, but the various GroupName constants and +groupName comments were widely inconsistent in the examples. That lead to a working codegen, but when trying to actually use the generated fake client, one would end with errors like
Note the API group
example, which is neitherexample.devnorexample.some.corpand so things won't work.It is also seemingly necessary to attach a +groupName to the doc.go of every version, not just their parent package.
I included the three sample tests I adopted from upstream. They helped me ensure it's all working and I guess can help us ensure it keeps working, so I added testing the examples module to
make test.Release Notes