Allow disabling address resolution #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When client does DNS lookup by itself and provides raw IP addresses to XMemcachedClient - it should be possible to disable any automatic hostname resolution. Otherwise it might cause conflicts. For the same purpose client should be able to remove a server using raw address, not a host name. Exposed method should be renamed to removeServer to be consistent with a complimentary pair of addServer methods.
killme2008
reviewed
Apr 29, 2020
Owner
|
@mirlord Thank u. |
Contributor
Author
|
Damn, I'm sorry for a broken build. I renamed a method at the very last moment and forgot to verify it. Thanks for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When client does DNS lookup by itself and provides raw IP addresses
to XMemcachedClient - it should be possible to disable any automatic
hostname resolution. Otherwise it might cause conflicts.
For the same purpose client should be able to remove a server using
raw address, not a host name. Exposed method should be renamed to
removeServer to be consistent with a complimentary pair of addServer
methods.