-
Couldn't load subscription status.
- Fork 304
refactor: reorganize Kubernetes client models into separate files #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This refactor reorganizes Kubernetes client model interfaces by moving them from the root namespace to a dedicated Models subfolder and updating the namespace from k8s to k8s.Models.
- Moved interface files (IStatus, ISpec, IMetadata, IItems) from root to Models folder
- Updated namespace from
k8stok8s.Modelsfor better organization - Updated project file references to reflect new file locations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/KubernetesClient/Models/IStatus.cs | Updated namespace from k8s to k8s.Models |
| src/KubernetesClient/Models/ISpec.cs | Moved interface to Models folder with updated namespace |
| src/KubernetesClient/Models/IMetadata.cs | Moved interface to Models folder with updated namespace |
| src/KubernetesClient/Models/IItems.cs | Moved interface to Models folder with updated namespace |
| src/KubernetesClient/ISpec.cs | Removed original file |
| src/KubernetesClient/IMetadata.cs | Removed original file |
| src/KubernetesClient/IItems.cs | Removed original file |
| src/KubernetesClient.Classic/KubernetesClient.Classic.csproj | Updated file references to new Models folder paths |
| src/KubernetesClient.Aot/KubernetesClient.Aot.csproj | Updated file references to new Models folder paths |
| examples/clientset/Program.cs | Added using directive for k8s.Models namespace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.