migrate to record

[tg123]

1 using record C# 9
2 add required to field to replace validate() C# 11
3 IntStrIntOrString -> IntOrString
4 IntOrString and ResourceQuantity are now struct instead of class for performance

[Copilot]

Pull Request Overview

This PR migrates the Kubernetes client library to use modern C# features, specifically C# 9 records and C# 11 required fields. The migration replaces traditional classes with records, eliminates constructor-based validation in favor of required field annotations, and renames the IntstrIntOrString type to the more concise IntOrString.

• Converts classes to records for immutable data modeling using C# 9 syntax
• Replaces validation methods with required field annotations from C# 11
• Renames IntstrIntOrString to IntOrString for better naming consistency

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/KubernetesClient.Tests/KubernetesYamlTests.cs	Updates test class to record and object initializer syntax
tests/KubernetesClient.Tests/IntOrStringTests.cs	Updates type references from IntstrIntOrString to IntOrString
tests/E2E.Tests/MinikubeTests.cs	Converts constructor calls to object initializer syntax
tests/E2E.Aot.Tests/MinikubeTests.cs	Converts constructor calls to object initializer syntax
src/LibKubernetesGenerator/templates/ModelExtensions.cs.template	Removes entire template file for model extensions
src/LibKubernetesGenerator/templates/Model.cs.template	Major refactor to generate records with required fields instead of classes with constructors
src/LibKubernetesGenerator/VersionConverterStubGenerator.cs	Removes entire version converter stub generator
src/LibKubernetesGenerator/ModelGenerator.cs	Updates to support record generation and type overrides
src/LibKubernetesGenerator/ModelExtGenerator.cs	Removes entire model extension generator
src/LibKubernetesGenerator/KubernetesClientSourceGenerator.cs	Removes references to deleted generators
src/LibKubernetesGenerator/GeneralNameHelper.cs	Removes IValidate interface and updates default parameter value
src/LibKubernetesGenerator/ClassNameHelper.cs	Adds special handling for int-or-string format
src/KubernetesClient/Models/*.cs	Updates model classes to records and removes validation methods
src/KubernetesClient/IValidate.cs	Removes entire validation interface
examples/*.cs	Updates example code to use object initializers and record syntax

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/KubernetesClient/Models/V1Patch.cs:54

• The constructor validation logic checks if Content is null after assignment, but the Content property has [JsonInclude] and is settable. Consider making the Content property required instead of performing null validation in the constructor to align with the C# 11 migration described in the PR.

        public V1Patch(object body, PatchType type)
        {
            Content = body;
            Type = type;

            if (Content == null)
            {
                throw new ArgumentNullException(nameof(Content), "object must be set");
            }

            if (Type == PatchType.Unknown)
            {
                throw new ArgumentException("patch type must be set", nameof(Type));
            }
        }

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

ToString() can return null when Value is null, which may cause issues for consumers expecting a non-null string. Consider returning string.Empty or a default value when Value is null.

Suggested change

	return Value;
	return Value ?? string.Empty;

[Copilot]

The implicit operator calls ToDecimal() on a struct that could be in an uninitialized state. Since ResourceQuantity is now a struct, accessing _unitlessValue when uninitialized could cause issues. Consider adding null/default checks.

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123, WeihanLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment