Skip to content

add patch example #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2018
Merged

add patch example #189

merged 2 commits into from
Jul 9, 2018

Conversation

@tg123
Copy link
Member

@tg123 tg123 commented Jul 3, 2018

exmaples for #179

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2018
brendandburns
brendandburns reviewed Jul 3, 2018
View reviewed changes
examples/patch/Program.cs Outdated
PrintLables(client.ReadNamespacedPod(name, "default"));
}

private static void PrintLables(V1Pod pod)
Copy link
Contributor

@brendandburns brendandburns Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PrintLabels

Copy link
Contributor

@brendandburns brendandburns Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and below)

@brendandburns
Copy link
Contributor

brendandburns commented Jul 3, 2018

Thanks! one small spelling typo :)

@brendandburns
Copy link
Contributor

brendandburns commented Jul 9, 2018

LGTM, thanks!

@brendandburns brendandburns merged commit d014467 into kubernetes-client:master Jul 9, 2018
JonJam pushed a commit to JonJam/csharp that referenced this pull request Sep 8, 2018
@tg123 @JonJam
add patch example (kubernetes-client#189)
c18d8b2 
* add patch example

* fix typo
@tg123 tg123 deleted the patch_example branch March 6, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns brendandburns left review comments

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tg123 @brendandburns @k8s-ci-robot