Add namespace To Context

[swcho]

Thank you for your efforts on this project.

I'd like to add namespace in Context object and properly parsed from configuration file.

Thank you.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[itowlson]

@swcho Thanks for the contribution! Can you clarify your intended scope here? It looks like this will surface the namespace in a kubeconfig to the JavaScript Context objects, but doesn't appear to use the namespace in any operations involving the context. Is that your intention?

[brendandburns]

@itowlson I think that's a reasonable feature to support, since I don't think we can/should set the default namespace in the client via this parameter, but making it available to users of the client library makes sense.

@swcho you need to sign the CNCF CLA, also will you add a unit test to validate this behavior?

Thanks!

[swcho]

@itowlson
Thank you for reviewing.

It is somehow trivial change but as document described below namespace is one of configurable item and I think it is beneficial for developer to have access to it.
Define clusters, users, and contexts

Especially, on-premise kube cluster, not like kube cluster provisioned via major cloud vendor, namespace can be utilized to encapsulate service environment.

My use case is below. And I just want to have namespace access-able through official client library.
https://github.com/swcho/kube-eye/blob/486ebc5c5f562d95ff9b472517b99131e2140f30/src/server.tsx#L32-L39

@brendandburns
As soon as I have some time to make unit test, I will try it.

Thank you all for having some time to review.

[drubin]

Some minor stylistic comments. But I think this would be a great addition.

Might even be nice to add an example showing the usage?

[drubin]

Should this not be just namespace like the others and set to undefined if not set?

[drubin]

Could we standise on one of the above to formats? Not sure which one is better though.

[brendandburns]

|| syntax is fine with me, and agree standardization is good.

[swcho]

@brendandburns

Sorry for late reply, I added simple test case for namespace access.

1695e27

Thank you.

[brendandburns]

@swcho looks good to me, I added a suggestion based on @drubin 's comment above, if you're ok with that, then I think this is ready to merge.

Thanks

[drubin]

/lgtm

[brendandburns]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, swcho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment