- 
                Notifications
    
You must be signed in to change notification settings  - Fork 559
 
Assign value to exec attribute to fix exec auth issue #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign value to exec attribute to fix exec auth issue #219
Conversation
| 
           Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks. 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.  | 
    
57496fc    to
    21bfc51      
    Compare
  
    | 
           /check-cla  | 
    
    
      
        1 similar comment
      
    
  
    | 
           /check-cla  | 
    
| 
           @rvichery thanks for the PR! Can you squash the commits and make sure they are both tied to the email in your github profile, then the CLA bot will do the right thing and we can merge this. Thanks!  | 
    
ec12d2c    to
    694d725      
    Compare
  
    | 
           /lgtm  | 
    
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, rvichery The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
As mentioned in #216, the exec attribute value was missing from the object when trying this library from master branch. I tested this change locally with an EKS cluster.