Skip to content

Support to refresh the tokens correctly when client-secret is set empty #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Support to refresh the tokens correctly when client-secret is set empty #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/oidc_auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import https = require('https');
import { Client, Issuer } from 'openid-client';
import { Client, ClientMetadata, Issuer } from 'openid-client';
import request = require('request');
import { base64url } from 'rfc4648';
import { TextDecoder } from 'util';
Expand Down Expand Up @@ -104,9 +104,15 @@ export class OpenIDConnectAuth implements Authenticator {

private async getClient(user: User): Promise<Client> {
const oidcIssuer = await Issuer.discover(user.authProvider.config['idp-issuer-url']);
return new oidcIssuer.Client({
const metadata: ClientMetadata = {
client_id: user.authProvider.config['client-id'],
client_secret: user.authProvider.config['client-secret'],
});
};

if (!user.authProvider.config['client-secret']) {
metadata.token_endpoint_auth_method = 'none';
}

return new oidcIssuer.Client(metadata);
}
}