Fix tlsv1.3 handshake issue #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client handshake output buffer has data, it needs to be sent. Otherwise, the handshake will fail, especially for TLSv1.3 .
If SEC_I_RENEGOTIATE is received when using TLS1.3: Prepare OutSecBuff and InSecBuff and pass the received data to InitializeSecurityContext. - If SEC_E_OK and there is no SECBUFFER_EXTRA buffer in OutSecBuff, receive the next packet and call Decryptmessage. - If SEC_E_OK and OutSecBuff has a SECBUFFER_EXTRA buffer, pass the SECBUFFER_EXTRA buffer to Decryptmessage. [1]: https://learn.microsoft.com/en-us/windows/win32/secauthn/renegotiating-an-schannel-connection [2]: https://learn.microsoft.com/en-us/answers/questions/1375213/how-to-handle-a-sec-i-renegotiate-received-in-tls
Owner
|
@windowsair I'm sorry, I had completely forgotten about this. Would you say this is ready to be merged? Then I'll do so and make a new release. |
Contributor
Author
|
@laudrup Yes, it's ready for review. Sorry, I've been too busy recently and haven't done much testing. |
Owner
|
@windowsair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91
That’s only part of it. Besides, we need to handle the
SEC_I_RENEGOTIATEsituation.I’m not sure when I’ll be able to finish them.