tapgarden: prevent shutdown on non-critical Custodian errors

[ffranr]

Fixes tapd crash as reported here: #1923

Downgrade various runtime errors in the Custodian from critical to non-critical to prevent the entire tapd daemon from shutting down. Errors during proof lookups, proof reception, and wallet transaction inspection are now logged with error messages, allowing the main event loop to continue processing other events. This ensures that isolated failures for specific assets or transfers do not crash the application.

[gemini-code-assist]

Summary of Changes

Hello @ffranr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of the tapd daemon by reclassifying several runtime errors within the Custodian's event loop from critical to non-critical. This change ensures that isolated failures related to specific assets or transfers, such as issues with proof availability or wallet transaction inspection, no longer lead to a complete application crash, thereby improving overall system stability and availability.

Highlights

• Error Handling Downgrade: Critical runtime errors within the Custodian's mainEventLoop have been downgraded to non-critical, preventing the entire tapd daemon from shutting down due to isolated issues.
• Improved Robustness: Errors encountered during proof lookups, proof reception, and wallet transaction inspection are now logged as errors, allowing the event loop to continue processing other events instead of terminating.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly downgrades several errors in the Custodian from critical to non-critical, which prevents the daemon from shutting down on isolated failures. The changes in tapgarden/custodian.go replace error returns with logging statements, allowing the event loop to continue. This is a solid improvement for application stability. My feedback is focused on aligning the new logging statements with the project's structured logging style guide to improve log parsing and maintain consistency.

[coveralls]

Pull Request Test Coverage Report for Build 20854548109

Details

• 3 of 11 (27.27%) changed or added relevant lines in 1 file are covered.
• 420 unchanged lines in 33 files lost coverage.
• Overall coverage decreased (-0.3%) to 56.609%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tapgarden/custodian.go	3	11	27.27%

Files with Coverage Reduction	New Missed Lines	%
commitment/tap.go	1	85.65%
asset/asset.go	2	80.54%
asset/group_key.go	2	72.15%
fn/func.go	2	58.82%
tapdb/assets_common.go	2	77.97%
tapdb/migrations.go	2	76.19%
tapdb/mssmt.go	2	88.64%
tapdb/sqlc/mssmt.sql.go	2	47.02%
tapdb/sqlc/transfers.sql.go	2	82.65%
universe_rpc_diff.go	2	76.0%

Totals
Change from base Build 20853146017:	-0.3%
Covered Lines:	65132
Relevant Lines:	115056

---

💛 - Coveralls

[GeorgeTsagk]

LGTM