Fix flaky assertion bound in testThreadSafetyBruteForce #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local compaction depends on completion order and timing. Under certain cases node count can reach or exceed `sqrt(concurrency)` before the final compaction is triggered. The test for intermediate state was failing fairly often in CI. This commit updates the test for intermediate state to simply be less than `concurrency`. This should satisfy the intent of the test, with the added security of the rest of the test asserting the finalized state is less than 2 nodes.
|
Based on my understanding of #186 this is a reasonable change. Though i'm not exactly sure why the original limit was introduced. In CI (and very rarely locally) i was able to repro it where its exactly |
yaauie
reviewed
Oct 22, 2025
src/test/java/org/logstash/plugins/inputs/http/util/ExecutionObserverTest.java
Outdated
Show resolved
Hide resolved
yaauie
approved these changes
Oct 22, 2025
…bserverTest.java Co-authored-by: Rye Biesemeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local compaction depends on completion order and timing. Under certain cases node count can reach or exceed
sqrt(concurrency)before the final compaction is triggered. The test for intermediate state was failing fairly often in CI. This commit updates the test for intermediate state to simply be less thanconcurrency. This should satisfy the intent of the test, with the added security of the rest of the test asserting the finalized state is less than 2 nodes.Closes #200