Skip to content

Backport test fix #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Backport test fix #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b2d83
Update src/test/java/org/logstash/plugins/inputs/http/util/ExecutionO…
donoghuc Oct 22, 2025
401976a
Fix flaky assertion bound in testThreadSafetyBruteForce
donoghuc Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/java/org/logstash/plugins/inputs/http/util/ExecutionObserverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ void testThreadSafetyBruteForce() {
assertThat(maxConcurrency.get(), is(greaterThan(1)));
assertThat(maxNodes.get(), is(lessThanOrEqualTo(concurrency * 2)));

// without queries, we should at least have some compaction
// without queries, we may have some compaction so we shouldn't be too strict
final ExecutionObserver.Stats preCompactionStats = observer.stats();
assertThat(preCompactionStats.executing, is(0));
assertThat(preCompactionStats.nodes, is(both(greaterThan(0)).and(lessThan((int) Math.sqrt(concurrency)))));
assertThat(preCompactionStats.nodes, is(both(greaterThan(0)).and(lessThan(concurrency))));

// query triggers tail compaction, leaving 2 or fewer nodes.
assertThat(observer.anyExecuting(), is(false));
Expand Down