-
Notifications
You must be signed in to change notification settings - Fork 159
Do not allow slash the beginning of the class pass in use #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @ihor-sviziev , |
After further investigation, I found that this rule is a part of PSR-12. Please check |
@lenaorobei could you defined which severity should be set for this rule? As for me - should be 6, similar to magento-coding-standard/Magento2/ruleset.xml Lines 457 to 460 in 199057a
@konarshankar07 I think it's good idea to re-use rules from PSR12 |
Agree with @ihor-sviziev, severity 6 is that we use for code style. And yes, it would be nice to reuse PSR12. Adding @coderimus since he is working on PSR12 update. |
@konarshankar07 do you have any updates? Do you have some working version? |
Hello @ihor-sviziev ... |
Not sure if this is helpful but PSR-12 support just made it in v2.18.0 of friendsofphp/php-cs-fixer (also not sure if this comment makes sense in this repo since the magento2 repo makes use of it but the coding-standard not, which is odd ...) |
use section does not actually need \ at the beginning of the classpath (leading backslash).
Let’s enforce it by static tests to prevent appearing such cases in future
Originally posted by @ihor-sviziev in magento/magento2#26129 (comment)
The text was updated successfully, but these errors were encountered: