Skip to content

No plugins in \Magento\Framework namespace #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbajsarowicz opened this issue Apr 24, 2020 · 1 comment
Open

No plugins in \Magento\Framework namespace #183

lbajsarowicz opened this issue Apr 24, 2020 · 1 comment
Labels
proposal New rule proposal

Comments

@lbajsarowicz
Copy link

lbajsarowicz commented Apr 24, 2020

Rule

Based on magento/magento2#27962:
\Magento\Framework cannot have plugins

Reason

Implementation

@lbajsarowicz lbajsarowicz added the proposal New rule proposal label Apr 24, 2020
@DmitryFurs
Copy link

@lbajsarowicz I also found 2 plugins in the commerce edition, and they are exactly the same

vendor/magento/module-scalable-checkout/etc/di.xml

<type name="Magento\Framework\Model\ResourceModel\Db\ObjectRelationProcessor">
    <plugin name="object_constraints_resolver" type="Magento\Framework\ForeignKey\ObjectRelationProcessor\Plugin" />
</type>

vendor/magento/module-scalable-oms/etc/di.xml

<type name="Magento\Framework\Model\ResourceModel\Db\ObjectRelationProcessor">
    <plugin name="object_constraints_resolver" type="Magento\Framework\ForeignKey\ObjectRelationProcessor\Plugin" />
</type>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal New rule proposal
Projects
None yet
Development

No branches or pull requests

2 participants