Skip to content

Change the bin directory #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Mar 8, 2019 · 1 comment
Closed

Change the bin directory #55

lenaorobei opened this issue Mar 8, 2019 · 1 comment
Assignees
@maderlock
Labels
accepted New rule is accepted bug Something isn't working event: MageTestFest2019 MageTestFest contributions Progress: good first issue Issues is easy to get started with

Comments

@lenaorobei
Copy link
Contributor

Preconditions

Have PHP CodeSniffer installed in the project.

Steps to reproduce

  1. Require magento/magento-coding-standard
  2. Run vendor/bin/phpcs -i

Expected result

  1. Magento coding Standard is present in the list of installed standards.

Actual result

  1. Magento coding Standard is missing in the list of installed standards.

How to Fix

Remove composer bin-dir, fix scripts to run vendor/bin/phpcs and change README.md.
@lenaorobei lenaorobei added bug Something isn't working Progress: good first issue Issues is easy to get started with labels Mar 8, 2019
@maderlock maderlock self-assigned this Mar 8, 2019
@lenaorobei lenaorobei added accepted New rule is accepted event: MageTestFest2019 MageTestFest contributions labels Mar 8, 2019
@maderlock maderlock mentioned this issue Mar 8, 2019
Merged
@maderlock
Copy link
Contributor

In addition to changing bin directory, added relative path from phpcs in vendor/bin to vendor/magento/magento-coding-standard that will be the base location phpcs needs when this repo is pulled in to a Magento 2 installation.

After this change, Magento is now included in list of installed standards both when downloaded stand-alone and as part of a Magento 2 installation.

magento-devops-reposync-svc pushed a commit that referenced this issue Sep 7, 2021
@svera
Merge pull request #55 from magento-commerce/imported-magento-magento…
3bd8317 
…-coding-standard-140

[Imported] #58 : Implement sniff for class properties PHPDoc formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maderlock maderlock

Labels
accepted New rule is accepted bug Something isn't working event: MageTestFest2019 MageTestFest contributions Progress: good first issue Issues is easy to get started with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maderlock @lenaorobei