Skip to content

[Bug] XssTemplateSniff does not detect some use cases #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Mar 19, 2019 · 0 comments · Fixed by #66
Closed

[Bug] XssTemplateSniff does not detect some use cases #65

lenaorobei opened this issue Mar 19, 2019 · 0 comments · Fixed by #66
Assignees
@lenaorobei
Labels
accepted New rule is accepted bug Something isn't working

Comments

@lenaorobei
Copy link
Contributor

Preconditions

Create fixture with following code:

<?= /* @noEscape */ json_encode($config) ?>

Steps to reproduce

Run Magento2 Coding Standard against this code.

Expected result

No issues detected.
/* @noEscape */ is allowed.
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/templates/template-security.html

Actual result

WARNING | Unescaped output detected.
@lenaorobei lenaorobei added bug Something isn't working accepted New rule is accepted labels Mar 19, 2019
@lenaorobei lenaorobei self-assigned this Mar 20, 2019
@lenaorobei lenaorobei mentioned this issue Mar 20, 2019
Merged
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 14, 2021
@sivaschenko
Merge pull request #65 from magento-commerce/imported-svera-magento-c…
ec62c5c 
…oding-standard-271

[Imported] Increased version to 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaorobei lenaorobei

Labels
accepted New rule is accepted bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XssTemplateSniff does not detect some use cases magento/magento-coding-standard
1 participant
@lenaorobei