Skip to content

Refactor PHPDoc search #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

udovicic
Copy link
Member

Resolves the issue where PHPDoc is not properly detected for constants as outlined in #134. Due to way search was done, it would fetch nearest comment, not the one belonging to current constant.

@udovicic udovicic added the bug Something isn't working label Aug 24, 2019
@udovicic udovicic requested a review from lenaorobei August 24, 2019 08:53
@lenaorobei lenaorobei merged commit c15d174 into magento:develop Aug 26, 2019
@udovicic udovicic deleted the bugfix/const-docblock-detection branch August 26, 2019 16:10
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 14, 2021
…#135)

* AC-1902: Remove PHPCSUtils dependency from coding standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants