#86: Fix AbstractApiSniff for classes without comment #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
approved these changes
Apr 18, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 1, 2021
…to-coding-standard-301 [Imported] AC-1159: Move eslint tests to magento-coding-standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sniff doesn't work correctly when there is no comment in the class to test. Therefore,
$commentStartPtrisfalseand the array lookup fails.Note: the sniff in its current form fails if there are multiple abstract classes defined in one file and one of the classes doesn't have a comment. That happens because we search for the previous comment open tag, regardless of if the tag belongs to the current class we are looking at or to a previous one.
To fix this would be out of scope for #86, though.